fix: re-fix markdownlint and cspell regressions on main - #464
Merged
Merged
Conversation
Individually-green PRs (#198, #293, #384, #385 after #292's cspell fix and #315's markdown fix) re-broke check:markdown and check:spelling on main within hours, because no CI workflow runs those checks (#392). - .cspell.yml: add 'lightboxes' (used in CONTRIBUTING.md), re-broken after #292's cspell-word merge. - LAUNCH.md, adr/README.md: fix MD060 compact-table pipe spacing. - README.md: fix MD009 trailing whitespace. - adr/stakeholder-outreach-draft-for-0001.md: add a language hint to the fenced draft-email block (MD040). Verified with a clean checkout: npm run check:spelling and npm run check:markdown both now exit 0. This does not add the CI job requested in #392 to run these checks on every PR: doing so requires pushing a .github/workflows/ci.yml change, which this environment's token cannot do (it lacks the OAuth 'workflow' scope, so GitHub rejects the push server-side). See the PR description for details. Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the specific lint regressions reported in #392: 12 markdownlint
errors across 4 files and 1 cspell error, all re-introduced by
individually-green PRs (#198, #293, #384, #385) shortly after #315 and
#292 had fixed them.
.cspell.yml: addlightboxes(used inCONTRIBUTING.md), re-brokenafter fix: add missing cspell words and drop phantom analyses path #292's cspell-word merge.
LAUNCH.md,adr/README.md: fix MD060 compact-table pipe spacing.README.md: fix MD009 trailing whitespace.adr/stakeholder-outreach-draft-for-0001.md: add a language hint tothe fenced draft-email block (MD040).
Verified on a clean checkout:
npm run check:spellingandnpm run check:markdownboth now exit 0.npm run test:unitandnpm run build:productionalso pass.What this PR does not do
#392's root-cause recommendation is to add a CI job that runs
check:spelling/check:markdown(and optionallycheck:format) onevery PR, so this kind of regression can't merge silently again. I
attempted that (a new
lintjob in.github/workflows/ci.yml), butthe token available to me lacks the OAuth
workflowscope, and GitHubrejects any push that touches
.github/workflows/*without it:That part of the fix needs a maintainer (or a token with
workflowscope) to land — the change is straightforward: a
lintjob that runsnpm run check:spellingandnpm run check:markdownafternpm ci.I'm leaving
check:formatout of that job even for a maintainer toadd later, since it currently fails on ~60 unrelated files across
mainand fixing that is a separate, much larger change.Fixes #392 (the reported regressions; the CI-wiring recommendation
remains open pending a
workflow-scoped push).— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:2545644