test(tide): cover the fork-403 diagnosis failures, the refused explanatory comment and the head-moved skip in the merge-queue path - #187
Merged
Conversation
![hivecommons-hive[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…atory comment and the head-moved skip in the merge-queue path explainForkWorkflows: compare/listFiles failures fall back to the raw failure with a debug line; a refused comment is a warning and the skip stands. evaluateInQueue: a head that moves during the unknown-state retry is skipped with no enqueue mutation. Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
Contributor
Author
/kind cleanup🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
github-actions
Bot
added
kind/cleanup
This was referenced Sep 26, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Covers the last four uncovered lines of
src/plugins/tide.ts(261-262, 280, 316), bringing it to 100% line coverage:__tests__/plugins/tide.test.ts(inside the existinga 403 on a fork pull requestdescribe):compareCommitsWithBasehead(500) abandons the diagnosis with a debug line, posts no comment, and the rawfailedverdict standspulls.listFiles(502) is handled the same wayskippedverdict still stands andcore.erroris not called__tests__/plugins/tideMergeQueue.test.ts: a head that moves while anunknownmergeable_state is retried is skipped withhead moved during evaluation, with noenqueuePullRequestmutation and no REST mergeFiles/functions claimed:
explainForkWorkflowsandevaluateInQueueinsrc/plugins/tide.tsonly. Disjoint from #173 (onPrLgtm), #175/#183/#185 (issueComment), #177 (labels), #179 (cronJobs/lgtm), #181 (utils/sleep).Verified:
npx vitest run __tests__/plugins/tide.test.ts __tests__/plugins/tideMergeQueue.test.ts→ 128 passed;npx eslintclean on both files.Related Issue
Closes #186
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88