Repository navigation
test(meow): cover the missing-issue-number throw and the response-body cancel fallback - #206
Merged
Merged
Conversation
…y cancel fallback Closes #205 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
Contributor
|
Please add a kind label with |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds two tests to
__tests__/issueCommentTest/meow.test.ts, the only file touched:meow(context)withpayload.issueremoved and asserts thegithub context payload missing issue numberrejection fires beforefetchorcreateCommentrun (src/issueComment/meow.ts:35).fetchwith a 503 whose body stream throws fromcancel(), then a good response; assertscore.debuglogscould not cancel cat api response bodyand the retry still posts the cat image (src/issueComment/meow.ts:112, thecancelResponseBodycatch).meow.tsgoes from 96.96% → 100% statements/lines/functions.npx vitest run __tests__/issueCommentTest/meow.test.ts→ 38 passed;npx eslintclean.Cluster:
src/issueComment/meow.tsonly — disjoint from #175 (assign/unassign/cc/uncc/reopen/close/retitle/lock), #183 (approve/milestone), #185 (trigger) and #196 (handleIssueComment).Related Issue
Closes #205
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88