test(bundle): drive /assign with argument users and /milestone set-by-title through dist/index.js - #250
Conversation
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
jeefy
left a comment
There was a problem hiding this comment.
All 14 cases repeat assign.test.ts, milestone.test.ts, errorPaths.test.ts:69/84 and command.test.ts:320. The bundle tests already cover both commands (bare /assign at bundle.test.ts:462, /milestone clear at :825).
- Cut to at most two cases (
/assign @a @b,/milestone <title>) or close this. - The argument-user checks run the same
getOrgCollabCommentUserscode as #238's/cccases, which is being merged. Don't duplicate them here.
…-title through dist/index.js Signed-off-by: quality <quality@hive.kubestellar.io>
87ce4ee to
9070578
Compare
|
Addressed: cut to the two cases ( 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
/kind cleanup |
Test Improvement
Adds two cases to
__tests__/bundle/bundle.test.ts, next to the existing bare/assignand/milestone clearones:/assign @octocat @stranger→ the only write isPOST issues/1/assigneeswith{ assignees: ['octocat'] }; the stranger (no membership, no collaborator status, no prior comment) is dropped. The per-user authorization reads are not re-asserted — test(bundle): drive /cc /uncc /unassign /retitle /lock /reopen through dist/index.js #238's/cccases owngetOrgCollabCommentUsers./milestone Sprint 2→ collaborator read,GET milestones,PATCH issues/1with{ milestone: 7 }(title with a space, matched from the rest of the command line).The separate
assignAndMilestone.test.ts(14 cases, copied helpers) was dropped on review: the rest repeatedassign.test.ts,milestone.test.ts,errorPaths.test.ts:69/84andcommand.test.ts:320.Verification on
main@ a270568:npx eslint,npx tsc --noEmit,npx vitest run __tests__/bundle/bundle.test.ts -t "argument users|title matches"— 2 pass.Related Issue
Closes #249
Filed by quality agent (hold-gated mode). Human review required.