Skip to content

test(bundle): drive /assign with argument users and /milestone set-by-title through dist/index.js - #250

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-bundle-assign-milestone
Oct 3, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-bundle-assign-milestone

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Test Improvement

Adds two cases to __tests__/bundle/bundle.test.ts, next to the existing bare /assign and /milestone clear ones:

  • /assign @octocat @stranger → the only write is POST issues/1/assignees with { assignees: ['octocat'] }; the stranger (no membership, no collaborator status, no prior comment) is dropped. The per-user authorization reads are not re-asserted — test(bundle): drive /cc /uncc /unassign /retitle /lock /reopen through dist/index.js #238's /cc cases own getOrgCollabCommentUsers.
  • /milestone Sprint 2 → collaborator read, GET milestones, PATCH issues/1 with { milestone: 7 } (title with a space, matched from the rest of the command line).

The separate assignAndMilestone.test.ts (14 cases, copied helpers) was dropped on review: the rest repeated assign.test.ts, milestone.test.ts, errorPaths.test.ts:69/84 and command.test.ts:320.

Verification on main @ a270568: npx eslint, npx tsc --noEmit, npx vitest run __tests__/bundle/bundle.test.ts -t "argument users|title matches" — 2 pass.

Related Issue

Closes #249


Filed by quality agent (hold-gated mode). Human review required.

@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner September 30, 2026 23:13
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 14 cases repeat assign.test.ts, milestone.test.ts, errorPaths.test.ts:69/84 and command.test.ts:320. The bundle tests already cover both commands (bare /assign at bundle.test.ts:462, /milestone clear at :825).

  1. Cut to at most two cases (/assign @a @b, /milestone <title>) or close this.
  2. The argument-user checks run the same getOrgCollabCommentUsers code as #238's /cc cases, which is being merged. Don't duplicate them here.

…-title through dist/index.js

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot force-pushed the quality/test-bundle-assign-milestone branch from 87ce4ee to 9070578 Compare October 3, 2026 05:18
@hivecommons-hive hivecommons-hive Bot changed the title test(bundle): drive /assign argument users and /milestone set-by-name through dist/index.js test(bundle): drive /assign with argument users and /milestone set-by-title through dist/index.js Oct 3, 2026
@hivecommons-hive hivecommons-hive Bot added agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance labels Oct 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Addressed: cut to the two cases (/assign @octocat @stranger, /milestone Sprint 2), now inline in bundle.test.ts beside the bare /assign and /milestone clear tests using the shared comment/repo/token helpers; the /assign case asserts only the write and leaves the per-user authorization reads to #238's /cc cases. Separate file deleted. Rebased on main @ a270568.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 9070578

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asks addressed, thanks.

@jeefy

jeefy commented Oct 3, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 3, 2026
@github-actions
github-actions Bot merged commit 84e3e01 into main Oct 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] bundle e2e suite never drives /assign with argument users or /milestone set-by-name through dist/index.js

1 participant