Repository navigation
test(bundle): drive meow.ts:28 (strict /meow re-check after the dispatcher's generic match) through dist/index.js - #397
Conversation
…tcher's generic match) through dist/index.js handleIssueComment admits /meow with the generic, case-insensitive, argument-tolerant matcher; meow() then re-checks the line against its own strict pattern and returns at meow.ts:28 when only the first gate matched. The arm was reached only by the unit suite. The new file runs /meow cat, /MEOW and a multi-line /meow please through the bundle and asserts exit 0 with no GitHub and no cat api calls. Closes #396 Signed-off-by: quality <quality@hive.kubestellar.io>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
jeefy
left a comment
There was a problem hiding this comment.
All three rows reach only meow.ts:28.
meowCommandShape.test.ts:44: drop the/MEOWrow. It locks in a bug: docs/commands.md:8 says commands are case-insensitive, but the pattern at meow.ts:12 has noiflag, so/MEOWis dispatched and then silently dropped.:45: drop the "among other lines" row. Keep/meow cat(:43).
Signed-off-by: quality <quality@hive.kubestellar.io>
|
Addressed in 9beaa55: dropped the 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Test Improvement
Adds
__tests__/bundle/meowCommandShape.test.ts, which drivessrc/issueComment/meow.ts:28— the earlyreturnof the strict/meowre-check — throughdist/index.js.handleIssueCommentadmits/meowwith the generic matcher (src/utils/command.ts:150-155, case-insensitive, arguments allowed);meow()then re-checks the line againstsrc/issueComment/meow.ts:12(/^[\t ]*\/meow[\t ]*$/) and returns at:28when only the generic gate matched. Until now that arm was reached only by the unit suite (__tests__/issueCommentTest/meow.test.ts:97); onorigin/main+ all 36 held bundle heads,npm run test:coverage:e2ereportedmeow.ts28,112uncovered.Three bodies run with
prow-commands: /meow:/meow cat,/MEOW, and/meow pleasebetween other lines. Each asserts exit 0, no::error::/::warning::, zero GitHub calls and — viacatApiPreload.cjsfail-closed withoutCAT_API_URL— zero cat api calls.npx vitest run __tests__/bundle/meowCommandShape.test.ts: 3/3 passDA:28,3formeow.tsnpx eslinton the new file: cleanNew file on purpose:
__tests__/bundle/meow.test.tsis owned by held PR #372. Nosrc/ordist/change.Related Issue
Closes #396
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88