[hivecommons-hive]

Test Improvement

Adds a third case to __tests__/bundle/commandCanonicalization.test.ts driving canonicalCommand's dynamic arm in handleIssueComment.ts:91 through the compiled dist/index.js: a /remove-<key> listed in prow-commands whose base is no built-in command names the <key> label section, so it enables the whole /<key> family (docs/commands.md: "Listing an alias in prow-commands enables the whole command family").

• prow-commands: /remove-triage with labels: { triage: { values: [accepted] } } in prow.yaml; /triage accepted → one POST /issues/1/labels with triage/accepted

Previously only the /remove-help alias-table path was exercised through the bundle. The removal form's missing-section error is covered by prefixedRemoveArms.test.ts.

Test-only change; no src/ or dist/ edits.

Related Issue

Refs #466

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[github-actions]

Please add a kind label with /kind failing-test or /kind cleanup.

[mrbobbytables]

Review: looks good; one minor nit.

• The fourth test asserts the full error string, including the Error: prefix and the yaml malformed wording, which breaks if the message is reworded. Consider matching only expected 'nosuch' top level key.

[jeefy]

All four cases reach only the two arms at handleIssueComment.ts:91.

• Keep dynamicRemoveCanonicalization.test.ts:43–56; drop :58–69, :71–82 and :84–94, and the issueRead/labelDelete consts at :17–18 they use. :71 is the "duplicates collapse" case #357 already dropped, and the missing-section error at :84 is covered by prefixedRemoveArms.test.ts:34.
• Minor: at :45, use repoLabels('triage/accepted') from ./helpers. The kept case would also fit as a third case in commandCanonicalization.test.ts, which has the same scaffold.

[mrbobbytables]

Addressed review: kept only the /remove-triage → /triage accepted case, now a third case in commandCanonicalization.test.ts (same scaffold, uses repoLabels('triage/accepted')); dropped the removal-form, duplicates-collapse and missing-section cases and the new file. Rebased on main.

[hivecommons-hive]

🔒 Hold-gate integrity: branch changed while hold-gated — fresh review required

This PR's branch moved while it sat hold-gated: the head recorded when the hold was applied was eb3625e92400, but the branch now sits at 0e1ce944cbed. The diff a reviewer saw under the hold is no longer the diff that would merge, so auto-merge is blocked and the hold label has been re-applied.

Commits not present in the hold-time snapshot (1):

• 0e1ce944cbed by mrbobbytables — test(bundle): drive canonicalCommand's dynamic /remove- arm through dist/index.js

Authors not in the hold-time author set: mrbobbytables

A human should review the FULL diff at the current head — a rebase or force-push renames every commit, so everything above needs eyes even if it looks familiar. Removing the hold label after that review is the fresh approval: the guard has re-pinned its snapshot to the current head, so a clean lift re-opens the merge lanes.

Dismissing stale review: the PR was revised after this review (commit post-dates it) and now implements the requested restructuring (single case, folded into the existing test file, fixture adjusted). Stack of #467–#482 verified locally: 78 bundle files / 481 tests pass, eslint clean.