Skip to content

FRLG: build maps from pinned Packages resources - #238

Merged
dayfine merged 11 commits into
frlg/stage7-celadonfrom
frlg/map-resource-handoff
Nov 7, 2026
Merged

dayfine merged 11 commits into
frlg/stage7-celadonfrom
frlg/map-resource-handoff

Conversation

@dayfine

@dayfine dayfine commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Stacked on fork #224 (frlg/stage7-celadon), also merging nav-core #114. Both dependencies are fork drafts; no upstream publication is requested. Simulation #56/#60 are published; the former #57/#58 tool dependencies are now on main.

FRLG builds its 53 maps from verified Packages resources instead of a second authored map directory. The resource lock and CI tools now pin approved PokemonSimulation main 906956e94fc912ae9adb0e44845da780f3bc7e4c, manifest 856e07a265da0b273172a7aa97a2aa335c90ea0a39162d50912b55fb60a86bc7. This explicitly adopts compact v2. All 53 maps preserve the previous v1 content under the v2 contract: coordinate spelling, grouping by kind and omitted empty sections change; terrain, triggers, metadata and per-kind order do not.

The existing native API still embeds prepared JSON at build time. CMake never downloads data or falls back to deleted source maps. The battle-data CLI forwards to the pinned Simulation exporter; all five BattleData files reproduce byte-for-byte. BDSP and its three held map differences remain separate.

How to review: read the lock, CMake/CI preparation adapter, CLI forwarder and devtools/maps/RESOURCE_MAPS.md. Almost all deletions are the 53 maps and duplicate Python builder/tests. Shared embed-path canonicalization and native parity tooling are inherited from #114. The fixture generator now accepts an explicit immutable publishing revision and normalizes v2 before item enrichment. The GCC checkpoint-helper fixes are committed in owning #222/#224 and merged here. Use git diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change origin/frlg/stage7-celadon...HEAD.

Validation:

  • Resource prepare/check verifies all 53 maps at the new pin; old native source maps are absent.
  • All five battle-data outputs reproduce unchanged; intended-base code health passes.
  • Native schema/legacy decoder and 150 complete plain/enriched map records pass on Linux and Windows at f3b7d5836e2b4c5b681079051ab85683310dbe96; macOS is queued. Enrichment changes 20 maps, so enriched variants are not accidental duplicates.
  • Latest head b24bc1848e3de582b91c46b71f71e8a85996dc83 includes both inherited test-helper fixes. Full validation: Linux, macOS, and Windows clang at fbc6ec2d1. Later differences from that Windows revision are parity tooling and a test-helper signature change. Results remain pending; superseded queued builds were cancelled.
  • Earlier v1 macOS/Windows builds completed; all 69 reported test failures were missing image fixtures (FileException). This does not establish a green full suite. The GCC helper warnings exposed by successive Linux builds are addressed in FRLG AutoStory 00.21-00.22: Route 6 to Vermilion, the S.S. Anne and HM01 #222/FRLG 00.26: the Bike Voucher, back to Cerulean, the Bicycle #224.

Upstream handoff still needs an agreed Packages data submission. No console/save/profile changes.

Detailed handoff and next export gates: agent run record.

Latest validation update: the v2 Windows build at fbc6ec2d1 completed with 32,964 passing cases and 69 failures, all missing-image FileExceptions; no other failed assertions were reported. Latest Linux at b24bc1848 compiles and has reached its test step. macOS remains queued.

@dayfine
dayfine marked this pull request as ready for review November 7, 2026 04:15
@dayfine
dayfine merged commit fa131a8 into frlg/stage7-celadon Nov 7, 2026
10 of 19 checks passed
@dayfine
dayfine deleted the frlg/map-resource-handoff branch November 7, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant