Repository navigation
FRLG: build maps from pinned Packages resources - #238
Merged
Merged
Conversation
dayfine
marked this pull request as ready for review
November 7, 2026 04:15
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on fork #224 (
frlg/stage7-celadon), also merging nav-core #114. Both dependencies are fork drafts; no upstream publication is requested. Simulation #56/#60 are published; the former #57/#58 tool dependencies are now on main.FRLG builds its 53 maps from verified Packages resources instead of a second authored map directory. The resource lock and CI tools now pin approved PokemonSimulation main
906956e94fc912ae9adb0e44845da780f3bc7e4c, manifest856e07a265da0b273172a7aa97a2aa335c90ea0a39162d50912b55fb60a86bc7. This explicitly adopts compact v2. All 53 maps preserve the previous v1 content under the v2 contract: coordinate spelling, grouping by kind and omitted empty sections change; terrain, triggers, metadata and per-kind order do not.The existing native API still embeds prepared JSON at build time. CMake never downloads data or falls back to deleted source maps. The battle-data CLI forwards to the pinned Simulation exporter; all five BattleData files reproduce byte-for-byte. BDSP and its three held map differences remain separate.
How to review: read the lock, CMake/CI preparation adapter, CLI forwarder and
devtools/maps/RESOURCE_MAPS.md. Almost all deletions are the 53 maps and duplicate Python builder/tests. Shared embed-path canonicalization and native parity tooling are inherited from #114. The fixture generator now accepts an explicit immutable publishing revision and normalizes v2 before item enrichment. The GCC checkpoint-helper fixes are committed in owning #222/#224 and merged here. Usegit diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change origin/frlg/stage7-celadon...HEAD.Validation:
f3b7d5836e2b4c5b681079051ab85683310dbe96; macOS is queued. Enrichment changes 20 maps, so enriched variants are not accidental duplicates.b24bc1848e3de582b91c46b71f71e8a85996dc83includes both inherited test-helper fixes. Full validation: Linux, macOS, and Windows clang at fbc6ec2d1. Later differences from that Windows revision are parity tooling and a test-helper signature change. Results remain pending; superseded queued builds were cancelled.FileException). This does not establish a green full suite. The GCC helper warnings exposed by successive Linux builds are addressed in FRLG AutoStory 00.21-00.22: Route 6 to Vermilion, the S.S. Anne and HM01 #222/FRLG 00.26: the Bike Voucher, back to Cerulean, the Bicycle #224.Upstream handoff still needs an agreed Packages data submission. No console/save/profile changes.
Detailed handoff and next export gates: agent run record.
Latest validation update: the v2 Windows build at
fbc6ec2d1completed with 32,964 passing cases and 69 failures, all missing-imageFileExceptions; no other failed assertions were reported. Latest Linux atb24bc1848compiles and has reached its test step. macOS remains queued.