Accessibility: announce context menu open to screen readers - #357
Accessibility: announce context menu open to screen readers#357hesam-oxe wants to merge 2 commits into
Conversation
AbstractButton now exposes an accessible name from an explicit setAccessibleName() or, as a fallback, its tooltip, so icon-only buttons (close, mute, record, play) are named for screen readers without per-call-site fixes. FlatButton and SettingsButton also set the name from their text.
When a PopupMenu opens while a screen reader is active, fire a QAccessible::Focus event on the menu so NVDA/JAWS/ORCA announce it immediately instead of waiting for the next focus change.
|
|
|
This PR contents duplicate #356. Did you push to the wrong branch? |
|
Hi @ilya-fedin, thanks for catching this! You're absolutely right that commit 4a892e7 is duplicated from #356 — that was an oversight during branching. |
Did you rebase it without push? 14 hours passed but the commits didn't change |
|
Sorry, I forget it. |
Did you forget again? And you have unsolved review on the other PR |
3 participants
Summary
When a
Ui::PopupMenuopens while a screen reader is active, fire aQAccessible::Focusevent on the menu so NVDA/JAWS/ORCA announce it immediately (part of issue telegramdesktop/tdesktop#476).This is a self-contained change: it only emits an accessibility event in
PopupMenu::showPrepared()whenUi::ScreenReaderModeActive()is true; no menu logic or focus behavior is altered.Changes
ui/widgets/popup_menu.cpp: include<QtGui/QAccessible>and fireQAccessible::Focuson the menu after show under a screen reader.Related
feat/accessibility-complete-overhaul).Verification status
Phase 2-4 features implemented. Full functional verification requires a Qt6 build environment (the desktop-app Linux build compiles patched Qt6 from source inside Docker, which was not available in the implementation environment). CI validation requested. The
lib_uisubmodule must be updated to this branch head for the tdesktop side to build against the new accessible sub-item framework.