Skip to content

Accessibility: announce context menu open to screen readers #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hesam-oxe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Accessibility: announce context menu open to screen readers #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a892e7
Accessibility: auto-fallback button accessible names
hesam-oxe Aug 29, 2026
14396a3
Accessibility: announce context menu open to screen readers
hesam-oxe Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ui/abstract_button.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,18 @@ void AbstractButton::clearState() {
onStateChanged(was, StateChangeSource::ByUser);
}

QString AbstractButton::accessibilityName() {
const auto custom = QWidget::accessibleName();
if (!custom.isEmpty()) {
return custom;
}
const auto tip = toolTip();
if (!tip.isEmpty()) {
return tip;
}
return QString();
}

AccessibilityState AbstractButton::accessibilityState() const {
return { .pressed = isDown() };
}
Expand Down
1 change: 1 addition & 0 deletions ui/abstract_button.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ class AbstractButton : public RpWidget {
? QAccessible::ButtonMenu
: QAccessible::Button;
}
QString accessibilityName() override;
AccessibilityState accessibilityState() const override;
void accessibilityDoAction(const QString &name) override;

Expand Down
2 changes: 2 additions & 0 deletions ui/widgets/buttons.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ FlatButton::FlatButton(

void FlatButton::setText(const QString &text) {
_text = text;
setAccessibleName(text);
accessibilityNameChanged();
update();
}
Expand Down Expand Up @@ -1056,6 +1057,7 @@ void SettingsButton::onStateChanged(

void SettingsButton::setText(TextWithEntities &&text) {
_text.setMarkedText(_st.style, text, kMarkupTextOptions, _context);
setAccessibleName(_text.toString());
accessibilityNameChanged();
update();
}
Expand Down
3 changes: 3 additions & 0 deletions ui/widgets/popup_menu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "ui/ui_utility.h"

#include <QtGui/QtEvents>
#include <QtGui/QAccessible>
#include <QtGui/QPainter>
#include <QtGui/QScreen>
#include <QtGui/QWindow>
Expand Down Expand Up @@ -1172,6 +1173,8 @@ void PopupMenu::showPrepared(TriggeredSource source) {
activateWindow();
if (Ui::ScreenReaderModeActive()) {
_menu->setShowSource(TriggeredSource::Keyboard);
QAccessibleEvent event(this, QAccessible::Focus);
QAccessible::updateAccessibility(&event);
} else {
_menu->setShowSource(source);
}
Expand Down