Repository navigation
v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording - #38
Open
gitluis wants to merge 3 commits into
Open
v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording#38gitluis wants to merge 3 commits into
gitluis wants to merge 3 commits into
Conversation
…md, fix stale wording (v1.16.15) - Delete js/views-database.js: an old "Database" section that index.html never loaded and nothing referenced. - The developer Changelog view showed a copy embedded in views-db.js that stopped at v1.4.1. It now fetches CHANGELOG.md when it opens (loadChangelog()); from file://, or when the request fails, it shows a note pointing to CHANGELOG.md. The file's own H1 is left out so the shell's title stays the page's only H1. - Overview: "No credit limit set · Add one" opens Settings → Credit cards, where the limit is now set (it opened Settings → Accounts). - README and CLAUDE.md §3, §4.3, §6, §18, §19 no longer point to the Data tab, Settings for transfer keywords, or a Theme tab. - CLAUDE.md §1 records Luis's desktop-only decision (2026-11-02). Version bumped in CHANGELOG, index.html, README, views-settings.js and CLAUDE.md §1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
v1.16.2: Fix Rebuild from your folder clearing everything when the folder has no CSV it can read
#25
Open
Open
gitluis
pushed a commit
that referenced
this pull request
Nov 2, 2026
…e-tab Merges cleanup-stale-docs-and-dead-code (#38), the top of the fix chain stacked on #21, so #10 can merge last. No rebase. Conflicts: - Versions: 1.17.0 kept in the footer, README, Settings -> General and CLAUDE.md §1. CHANGELOG: 1.17.0, then 1.16.15 ... 1.16.1, then 1.16.0. - CLAUDE.md: "Last updated" is #10's note followed by the chain's history; §3's views-db.js line names both the Database tab and the Changelog view that reads CHANGELOG.md. - views-db.js: #10's rebuilt DB Schema code, with #30's plan link note ({type,id}); the Changelog banner keeps "4. CHANGELOG" with #38's text and code (loadChangelog(), no embedded copy). - views-settings.js: #10's tab-bar comment and version line. - #10's wording about the embedded changelog, which #38 removed, is updated in CLAUDE.md §19 and the 1.17.0 entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
Open
33 tasks
…s-and-dead-code Carries master's v1.10.3-v1.10.5 up the stack: declined answers (#14), literal single "~" (#15) and the Import Logs race fix (#18), with clarity-insights' port of #14 to the rebuilt AI tab. One conflict: CLAUDE.md's "Last updated" line. Kept this branch's line and added the v1.10.3-v1.10.5 history. The CHANGELOG merged cleanly. Versions stay 1.16.15. renderImportLog() keeps #18's guards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
44 tasks
gitluis
pushed a commit
that referenced
this pull request
Nov 2, 2026
…e-status-indicator Brings the Clarity redesign and fix stack (#16-#21, #24-#38, #10) into #23, so its backup status can be rebuilt on the app bar. All seven files #23 touched conflicted (CHANGELOG.md, CLAUDE.md, README.md, index.html, js/core.js, js/views-data.js, js/views-settings.js). Each was resolved by taking the redesign's version: the sidebar #23 built on is gone. The tree now equals settings-database-tab at 477f357. The next commit rebuilds #23's changes on the app bar's sync badge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
Open
Open
This was referenced Nov 2, 2026
gitluis
pushed a commit
that referenced
this pull request
Nov 2, 2026
…database-tab Brings in the second fix chain (#24-#38 already merged here; now the twelve fixes v1.16.16-v1.16.27). Version stays v1.17.0; CHANGELOG runs 1.17.0, 1.16.27 ... 1.16.0, 1.10.5 ... Conflicts: - CHANGELOG.md: 1.17.0 entry on top of the chain's changelog. - README.md, index.html, js/views-settings.js, CLAUDE.md section 1: v1.17.0. - CLAUDE.md Last updated: #10's note, then the chain's history from v1.16.27. - js/views-db.js: #10's rewritten DB Schema kept; the chain's one change there (ruleCategories in the app_state note, v1.16.25) applied to #10's note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
…-stale-docs-and-dead-code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUZo6LRYpLthSp2PRi # Conflicts: # CLAUDE.md # js/views-settings.js
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A grouped housekeeping PR (§0 allows grouping minor changes). There's no new feature and no data change.
js/views-database.jsis deleted.index.htmlnever loaded it, and nothing referenced it.CHANGELOG.md. It showed a copy embedded inviews-db.jsthat stopped at v1.4.1. When the file can't be read, as when FinLens is opened as a file, it shows a short note pointing toCHANGELOG.md.What changed
1.
js/views-database.jsdatabaseview with Import / Accounts / Categories / Logs / Inspector sub-tabs, savingcurrentDbView.<script>tag inindex.html;dbSubviews,State.currentDbView, thedatabaseview) is used anywhere else;docs/archive/IMPLEMENTATION_STATUS.mdand earlier CHANGELOG entries still mention it.2. The in-app Changelog view (
changeloginjs/views-db.js)How it loaded:
CHANGELOG.md. The whole changelog was embedded inviews-db.jsas a block comment, read back withFunction.toString().What it does now:
loadChangelog()fetchesCHANGELOG.md(relative toindex.html,cache: 'no-cache') each time the view opens, normalizes CRLF, and renders it throughrenderMarkdown()with the same outline and styling as before.index.html. Open that file to read it." It adds why: either "FinLens is opened as a file here…" or "FinLens couldn't load it from this address."file://, no fetch is tried. Chrome, Edge and Firefox refuse to fetch files from a page opened as a file, and log a console error when you try.body.isConnected).# FinLens Changelogheading is left out. The view used to render it as a second H1, against CLAUDE.md §12 ("Views never render their own H1"); the shell's "Changelog" title is the page's H1.Why this approach:
file://, and there the file is sitting next toindex.html. This is a developer-only view.Scope in
views-db.js: only section 3 changed, from its banner comment to the end of the file. The DB Schema and DB Inspector code above it is untouched. (#30's one-word schema note change,{type,id}, is further up the file and merged without a conflict.)3. Stale wording
Fixed:
views-database.jsviews-db.jsnotes the Changelog readsCHANGELOG.mdname.segcredit_cardbalancecurrentBalances())js/views-main.js, Overview credit cardChecked and still accurate, so left alone:
wireAccountRename()); the Transfers diagram ("Where money moved").finlens_navCollapsed"left by the sidebar" (§20);data-goto,data-tabandshowView('…')points to a registered view or Settings tab.Found but not changed, because they're outside "README, CLAUDE.md and user-facing strings":
js/init.js:core.js,db.js,init.js,views-cleanup.js, and in CLAUDE.md §14. The tab exists; only the case differs.views-eval.jssays "the AI Analysis tab" in the text it writes into EVAL.md. Changing it would change regenerated eval docs.4. Desktop only
CLAUDE.md §1, under "What it does": Desktop only (Luis, 2026-11-02): FinLens targets desktop browsers; don't spend work on phone layouts. A separate mobile app is planned. The existing responsive CSS stays.
5. Version
v1.16.15 in:
CHANGELOG.md(new entry)index.htmlfooterREADME.md(badge and footer line)js/views-settings.jsNot verified
file://behavior relies on browsers refusing to fetch from a page opened as a file; Firefox and Safari do too by default, but neither was run.python -m http.server..callout.plain.test-clarity.jsstill pass.Automated checks: earlier run, not re-run · ecfcab2
Moved unchanged from this PR's "Test results" comment on 2026-11-04; not re-run, so not in the new table format. Originally a description section titled "How it was tested".
Headless Chromium (Playwright) at 1280×900 against
samples/(257 transactions), with the pinned CDN libraries served from npm, on this branch's final commitecfcab2, chained on #37. Each script ran asNODE_PATH=$(npm root -g) node <script> <repo> <outdir>, from one harness shared by every branch in the stack: the base suites, plus every test added by this PR or by a PR below it (cumulative regression).ecfcab2test-clarity.jstest-insights.jstest-finances.jstest-plan.jsboot.jsrace.jsrenderImportLog(the race #18 fixes on master; not in this stack)test-clear-edits.js(from #24)test-rebuild-folder.js(from #25)test-partial-import.js(from #26)test-json-import.js(from #27)test-new-browser-copy.js(from #28)test-json-export.js(from #29)test-plan-links.js(from #30)test-rule-flags.js(from #31, as updated by #32)test-drawer-flags.js(from #32)test-start-balance.js(from #33, as updated by #34)test-ai-summary-period.js(from #34)test-account-names.js(from #35)test-account-order.js(from #36)test-drawer-focus.js(from #37)test-cleanup.js(new in this PR)test-insights.js's "General: version line" check reads the version from theindex.htmlfooter, andtest-plan.js's "Budget: Save adds it" accepts a new budget with or without anid, requiring thebud_+ 10 base-36 format once it has one (v1.16.7: Fix transaction links to budgets, buckets and debts pointing at the wrong item after a delete #30 adds ids). Nothing else in the base suites changed.Measured before the chain
By the agent that wrote the fix, on
cf7199f(built on70c7125, v1.16.0; then numbered v1.16.12). The changelog counts there are for v1.16.0's CHANGELOG plus this entry; on this branch the test reads the stack's CHANGELOG, with every v1.16.x entry.Headless Chromium (Playwright) at 1280×900 against
samples/. CDNs are served from npm by the harness, overhttp://localhost:4173. All scripts ran asNODE_PATH=$(npm root -g) node <script> <worktree> <outdir>.New:
test-cleanup.js(21 checks).views-database.js: it's gone, and nothing inindex.html, README, CLAUDE.md (outside its history line) orjs/names it. Nodatabaseview is registered. Boot, the import, all 24 views and the Changelog: no request 404s or fails.CHANGELOG.md's top version first, and all 38 versions in order (37 before this entry);CHANGELOG.mdcan't be read:file://(scripts from disk): the note says FinLens is opened as a file, no fetch is tried, and there are no console errors.70c7125)cf7199f)test-cleanup.js(new)test-clarity.jstest-finances.jstest-plan.jstest-insights.js(version check reads the footer)boot.jsrace.jsThe 12 checks that failed before:
race.js: every error in every run isrenderImportLog(#18). The counts vary with machine load; the 9 came from a run with seven suites in parallel. None come from this change.No existing suite was edited.
Screenshots:
changelog-http.png,changelog-note.pngandchangelog-file.pngin the test output folder.Manual QA steps
Setup
git checkout cleanup-stale-docs-and-dead-code.index.htmlin Edge from disk (file://). Your usual data is fine: this PR doesn't change saving or importing.python -m http.server 8000. Leave it running.The Changelog view has no link in the app. You open it from DevTools: F12 → Console, type
showView('changelog')and press Enter.1. The app still boots and nothing asks for the deleted file
views-databasein the Network filter box.Expected:
views-database.jsappears (it was never loaded; there's no 404 either).2. Changelog opened as a file shows the note
file://, in the Console, runshowView('changelog').Expected:
CHANGELOG.md."index.html. Open that file to read it. FinLens is opened as a file here, and browsers don't let a page opened that way read other files."Before this fix: the view showed an old embedded copy that started at v1.4.1.
3. Changelog over http shows the real file
http://localhost:8000/index.html. (It's a different site to the browser, so it starts empty. Click Try it with sample data if you want data; the Changelog doesn't need it.)showView('changelog').document.querySelectorAll('h1').length.Expected:
CHANGELOG.md.1.4. Leaving the view while it loads
showView('changelog')and, straight away, click Overview in the app bar.Expected:
5. A missing CHANGELOG.md over http shows the note
CHANGELOG.mdtoCHANGELOG.bak. Start the server again.http://localhost:8000/index.htmland runshowView('changelog').Expected:
CHANGELOG.md.6. Overview "Add one" opens Credit cards
file://tab, make sure a credit card has no limit: Settings → Credit cards, clear Credit limit ($) for the card if it has one.Expected:
Before this fix: it opened Settings → Accounts, which has no limit field.
7. Regression: the DB views still work
file://tab, in the Console, runshowView('db-schema').showView('db-inspector').Expected:
8. Docs read correctly
README.md. Find "Other CSV" under Supported Accounts, and the Data Persistence steps.CLAUDE.md§1 and find Desktop only.Expected:
Please check before merging
CHANGELOG.mdand shows a note underfile://, with no embedded fallback copy.showView('changelog')in DevTools with FinLens served over http: the newest version is at the top. Opened as a file, the note shows.settings-database-tab(v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10, the DB tools rebuild), done on v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10's branch: this stack was merged into it so it can go last. Theviews-db.jsconflict was the 5-line banner above the Changelog section, resolved as planned: v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10's number ("4. CHANGELOG") with this branch's banner text and code. The version strings, CHANGELOG and CLAUDE.md conflicted as expected. v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10's own note that the embedded changelog "still stops at v1.4.1" was updated there too.https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
Generated by Claude Code