Repository navigation
v1.16.27: Minor fixes — Rebuild button label, account arrow labels, range label on developer views, stale wording - #50
Open
gitluis wants to merge 2 commits into
Conversation
…on developer views, stale wording (v1.16.27) Grouped minor changes (CLAUDE.md §0): - Data & reset: after Rebuild from your folder the button reads "Rebuilt". loadFiles() renders the tab partway through and used up DataCleanup.lastDone. DataCleanup.running now names the action under way; a render meanwhile shows its button as "Working…" and leaves lastDone for _done()'s render. What Rebuild does is unchanged. - Settings → Accounts: saving a name updates the row's ▲▼ aria-labels at once. - NO_RANGE_VIEWS (ui.js) includes db-inspector, db-schema, changelog, ai-eval and db-logs, so they no longer show the date-range label. - Comments: "data tab" (init.js) and "Data & Reset" (core.js, db.js, migrate.js, views-cleanup.js, views-data.js, init.js); CLAUDE.md §9, §12, §14, §20. - Version v1.16.27 in CHANGELOG.md, index.html, README.md, views-settings.js and CLAUDE.md §1 / Last updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
Open
v1.16.2: Fix Rebuild from your folder clearing everything when the folder has no CSV it can read
#25
Open
Open
Open
Open
…13.0) into minor-ui-wording-fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUZo6LRYpLthSp2PRi # Conflicts: # js/views-settings.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR groups four minor fixes into one branch and one commit, as CLAUDE.md §0 allows for minor changes. None of them changes what an action does or what data is stored.
Version v1.16.27 (§17): CHANGELOG.md,
index.htmlfooter, README (badge and footer),views-settings.js, and CLAUDE.md §1 and "Last updated".What changed
1. Rebuild button label (
js/views-cleanup.js)DataCleanup.lastDone, and the next render of the tab uses it up. Rebuild's import renders the tab twice partway through: once inloadFiles()and once inreloadFromDirHandle(). The first of those renders used uplastDone, so the final render from_done()showed the button as if nothing had run. Onecfcab2the button went "Rebuilt" (disabled, before the import had finished), then "Rebuild" (enabled, while the backup file was still being written), then "Rebuild".DataCleanup.runningnames the action under way, and_done()clears it. While it's set, a render shows that button as "Working…", disabled, and leaveslastDonealone. The click handler'sfinallyalso clearsrunning, in case an action ever returns without_done().2. Account order arrows (
js/views-data.js)aria-label="Move <old name> up"/"… down"until the tab rendered again.setAccountName()) doesn't render it.changehandler sets the row's two arrow labels to the name now shown. It usessetAttribute, so quotes,<and&come out exactly as a render gives them. Clearing the name brings back the default name, in the field and in the labels.3. Range label on developer views (
js/ui.js)db-inspector,db-schema,changelog,ai-evalanddb-logsall showed the range (for example "This Month") under their title. None of them reads the range: nofilteredTx(),State.rangeordescribeRange(), and the AI Eval works on the samples in its own All time sandbox.NO_RANGE_VIEWS, next to the Plan screens, Trends and Settings.db-tools: this view doesn't exist on this base, so it isn't added.4. Stale wording
js/init.js:handleFilePick()).core.js,db.js,init.js,migrate.js,views-cleanup.jsandviews-data.js, and in CLAUDE.md §14.DataCleanup.running. It's in-memory UI state, so §20's storage table doesn't change.Not changed
periodEndBalance()(js/aggregation.js):t.balance != nullbranch never runs, becausemkTx()andreconstituteTx()always setbalance: null(§4.2).periodEndBalance()'s override logic, and removing the branch here would conflict with it.currentBalances()has the same dead branch (thewithBallookup). It's left too, so the three balance helpers stay on one rule (§18). Both can go in one follow-up after that PR merges.docs/archive/,docs/eval-runs/, and the version history inside CLAUDE.md's "Last updated" line, where "Data & Reset" was the tab's name at v1.9.0 and v1.13.0.periodEndBalance()andbuildFinancialSummary().Not verified
FileSystemDirectoryHandle, as in the other suites.Automated checks: earlier run, not re-run · d0c3382
Moved unchanged from this PR's "Test results" comment on 2026-11-04; not re-run, so not in the new table format. Originally a description section titled "How it was tested".
Light checks, by Luis's call to save usage: on this branch's final commit
d0c3382(chained on #49) onlyboot.js,race.jsand this PR's own tests ran. Headless Chromium at 1280×900 againstsamples/, with the pinned CDN libraries served from npm; each script ran asNODE_PATH=$(npm root -g) node <script> <repo> <outdir>.d0c3382boot.jsrace.jstest-minor-fixes.js(new in this PR)Full set, once, on the top of the stack (#23,
819e809: every PR below it merged in): every base suite and every fix test from #24 to #50, plus #10's and #23's, each in its final variant. All pass:test-clarity.js55/55,test-insights.js137/137,test-finances.js126/126,test-plan.js127/127,boot.js257 transactions and 0 errors,race.js0 errors; #24–#38's tests (clear-edits 48/48, rebuild-folder 57/57, partial-import 47/47, json-import 28/28, new-browser-copy 10/10, json-export 31/31, plan-links 60/60, rule-flags 67/67, drawer-flags 36/36, start-balance 193/193, ai-summary-period 78/78, account-names 40/40, account-order 32/32, drawer-focus 167/167, cleanup 21/21); #39–#50's tests (drawer-fields 45/45, read-as 52/52, json-import-edits 29/29, overlapping-exports 46/46, override-balance 160/160, card-override 277/277, ai-summary-trend 91/91, transfer-user-type 39/39, untransfer-category 27/27, recategorize 55/55, retype-transfer 135/135, minor-fixes 34/34);test-dbtab.js73/73,test-save-status.js64/64,test-master-port.js16/16. Three scripts needed a test-only change on that run, listed in #23 and in the PRs they belong to; the app code wasn't changed.Chain edit to
test-minor-fixes.js: check "3 db-tools: not a registered view on this base" fails once v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10 is merged in, since v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10 registersdb-tools. On a base with it, the check now logs it instead (34/34 on the top of the stack).db-toolsisn't inNO_RANGE_VIEWS; not changed here.No phone checks (desktop only).
Measured before the chain
The numbers below are the PR author's, on the commit before it was chained (built on the old #38 tip
ecfcab2, v1.16.15, or on the fix below it there; version numbers renumbered to the chain's).Headless Chromium (Playwright) against
samples/, with the pinned libraries served from npm (the CDNs are blocked here). The machine was shared with other agents, so the suites ran one at a time.New
test-minor-fixes.js(35 checks). Boot imports the samples from a fake connected folder.<and&, and clear the name. The labels match what a render gives, other rows are untouched, and the arrows still move the account.ecfcab2(a temporarygit worktree, removed afterwards): 23/35 passed. All 12 failures are item 1–3 checks: 4 Rebuild-label checks, 3 arrow-label checks and 5 range-label checks. Every regression check passes there too.Every suite for this base (
run-tip.sh 15: the base suites plus each fix test of v1.16.1: Fix "Clear transaction edits" wiping every transaction when the browser database is empty #24–v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38), on the final commit3718f1a, one at a time. All passed:renderImportLogerror ("Cannot set properties of null"). It comes from v1.10.5: fix Import Logs throwing when the view is left before it loads #18's fix not being in this stack yet, and none of the errors comes from this change.Suites changed: none. One comment in
test-rebuild-folder.js(case D) says the button reads "Rebuild" after a rebuild. That comment is now out of date, but no check depends on it.How to reproduce the bug
Run these on the base branch,
fix-retyped-transfer-still-counted. Do the Setup from the testing steps below, but check outfix-retyped-transfer-still-countedinstead ofminor-ui-wording-fixes. Use the scratch folder with the samples only. The wording fixes (item 4) have nothing to reproduce.1. Rebuild button label
What goes wrong: the button reads Rebuilt too early, while the import is still running. It then flips back to Rebuild (enabled) while the backup is still being written, and ends as Rebuild, not Rebuilt.
2. Account arrows keep the old name
aria-label.Test & "Quote" <1>and press Tab.aria-labelagain, with no reload and no tab switch.What goes wrong: both arrows still read
Move <old name> up/… down. They only pick up the new name after the tab renders again.3. Range label on developer views
showView('db-inspector').showView('db-schema'),showView('changelog'),showView('ai-eval')andshowView('db-logs').What goes wrong: each of the five views shows This month under its title, though none of them uses the date range.
Manual QA steps
Setup
git checkout minor-ui-wording-fixes.samples/into a new scratch folder (e.g.C:\temp\finlens-50). Test 1 rebuilds from the folder, so never use your real folder.index.htmlin Edge. Settings (gear) → Import → Pick a folder, choose the scratch folder, allow read and write access.1. Rebuild shows "Rebuilt" when it finishes
Expected:
Before this fix: the button went Rebuilt too early, then back to Rebuild (enabled) while the backup was still being written.
2. Regression: the other Clean up buttons still show "Cleared"
Expected:
3. Account arrows use the new name right away
aria-label(e.g.Move <name> up).Test & "Quote" <1>and press Tab.aria-labelin Elements (no reload, no tab switch).Expected:
Move Test & "Quote" <1> up/… downstraight away.Before this fix: the labels kept the old name until the tab was rendered again.
4. Developer views don't show the date range label
showView('db-inspector').showView('db-schema'),showView('changelog'),showView('ai-eval')andshowView('db-logs').Expected:
5. Regression: range label still shows where it should, and hides where it did
Expected:
Please check before merging
showView('changelog')from DevTools. There should be no range under the title, and the top entry should be 1.16.27.index.html, README.md,views-settings.jsand CLAUDE.md (§1, §9, §12, §20, Last updated). It also appears in comments inui.js(v1.16.27) andviews-cleanup.js("Up to v1.16.26").t.balancebranches inperiodEndBalance()andcurrentBalances()in a follow-up, once theperiodEndBalance()PR has merged.https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
Generated by Claude Code