feat: map the Appliance response members from the 1.74.0 gap report - #419
Open
danielabbatt wants to merge 1 commit into
Open
danielabbatt wants to merge 1 commit into
danielabbatt wants to merge 1 commit into
Conversation
Eighteen members the v1.74.0 spec documents that the models lacked, the
third per-area batch: Security Group Tag settings on AppliancePort, Vlan and
SiteToSiteVpn; VRF settings on LanConfiguration, Neighbor and
TrafficUplinkPreference (reusing VlanVrf, the same {id, name} shape);
SiteToSiteVpn.HostTranslations; ThirdPartyVpnPeer.EcmpUplinkConfigs;
NetworkUmbrellaAccountConnectResponse.Umbrella; StaticRoute.IpVersion;
ThirdPartyVpnPeerEbgpNeighbor.ReceiveLimit. Nine new classes back the
nested objects.
Two more members that could never bind are corrected. VpnStatus's
ThirdPartyVpnPeers list was typed as the configuration wrapper whose only
member is "peers"; each status entry is {name, publicIp, reachability} and
the list is now List<VpnStatusThirdPartyVpnPeer>.
UpdateOrganizationApplianceDnsLocalRecordAsync returned the profile type
(only "id"); it now returns OrganizationApplianceDnsLocalRecordsResponse like
the create and list methods.
ApplianceMemberTests covers the new members and both corrections.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 9 complexity
Metric Results Complexity 9
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #418 → #417 → #416 → #415
Base is
feat/map-sm-members. Merge the chain in order with merge commits, then retarget this tomain. Changelog label1.74.13assumes that.What
Third per-area batch from
gap-report-v1.74.0.md: 18 Appliance members the spec documents that the models lacked, across 12 classes.AppliancePort.Sgt,Vlan.Sgt,SiteToSiteVpn.SgtAppliancePortSgt{id, enabled},VlanSgt{id},SiteToSiteVpnSgt{enabled}— the three differ in the specLanConfiguration.Vrf,Neighbor.Vrf,TrafficUplinkPreference.VrfVlanVrf{id, name}— identical shape, reused rather than triplicatedSiteToSiteVpn.HostTranslationsSiteToSiteVpnHostTranslation{name, local, remote}+…AddressThirdPartyVpnPeer.EcmpUplinkConfigsThirdPartyVpnPeerEcmpUplinkConfig{id, wan, privateSubnets, ebgpNeighbor}+…EbgpNeighborNetworkUmbrellaAccountConnectResponse.Umbrella…Umbrella→…Organization{id}StaticRoute.IpVersion,ThirdPartyVpnPeerEbgpNeighbor.ReceiveLimitint?Access follows the spec: read/update where the member is on a PUT body, read-only otherwise.
Two corrections (breaking in the type-system sense; both always came back empty)
VpnStatus.ThirdPartyVpnPeerswasList<ThirdPartyVpnPeers>— the configuration wrapper ({peers}), so each status entry deserialized to an object with an emptyPeers. The API sends{name, publicIp, reachability}; nowList<VpnStatusThirdPartyVpnPeer>.UpdateOrganizationApplianceDnsLocalRecordAsyncreturnedOrganizationApplianceDnsLocalRecordsProfile({id}only). The API returns the record; it now returnsOrganizationApplianceDnsLocalRecordsResponse, matching the create and list methods fix: correct response shapes and member names that could never bind #416 fixed.Verification
All edited files kept their BOM state and line endings. No code outside
Interfaces/Datareferenced the changed members.