Repository navigation
Hygiene after v0.6.7: cppqualcheck reports timeouts as timeouts, #382 review notes, CONTRIBUTING map rows - #393
Merged
Merged
Conversation
…ll timeouts
The repo-root arms each ran a cold --no-cache parse of the whole tree under a
30 s alarm, with stderr discarded, so a call killed on a slow sanitizer runner
surfaced as a wrong count ("expected 32") rather than a timeout.
- The repo-root arms share a per-run temp dir with one cache file per verb
(--uses reads the rich artifact, --callers the lean one): two cold parses,
four warm reads. Fixture arms keep --no-cache. The dir is removed on exit.
- run() keeps the call's exit status and prints an explicit TIMEOUT (rc=142)
or ERROR (rc=N) FAIL line naming the call; the gate fails on it, and a
repo-root arm compares its count only when the call succeeded.
- The binary flavour is detected once at the top (the section 9 nm probe, now
shared); a sanitizer binary gets a 90 s per-call alarm instead of 30 s.
No expected count or assertion changed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- src/ingest_importcap.h, src/graph.h: comments named the deleted capturePythonImportBinds; they now name emitCapturedPythonImportBind. Comment-only. - test/pyimportprecisecheck.sh: the "vocabulary is compiled in" arm grepped the bare capture names, which the Go tags.scm comment already carried, so it passed on a binary without the Python captures. It now greps the Python patterns themselves. - CHANGELOG: the #382 entry states that record content and the extraction version are unchanged while the order of a file's bind records differs; drop a doubled blank line. - queries/python/tags.scm: "C++ imposes" reads as the language; name the C++ side (ingest_importcap.h). - CONTRIBUTING: family table row 1 lists Python as reading @import.path; row 2 names the Python bind producer that replaced the deleted one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small hygiene follow-up after v0.6.7 and #382. Docs, tests and comments only; every answer is byte-identical (31/31 argv vs
main,--quality-deltagates 0).1.
test/cppqualcheck.sh: a timed-out call no longer reads as a wrong count. The repo-root arms ran each call cold under a 30 s alarm with stderr discarded, so on a slow runner (the ASan macOS leg on #382 took 28–30 s per arm) a killed call printed nothing and the arm saidexpected 32. Now:--usesand--callersread different cache tiers, so one file per verb);FAIL TIMEOUT (rc=142)and any other non-zero exitFAIL ERROR, naming the call;nmdetection).No count or assertion changed. With the alarm forced to 1 s, all six arms print TIMEOUT; before, they printed
expected N.2. #382 review notes (thanks again @LaimaWu):
capturePythonImportBindsin comments (src/ingest_importcap.h,src/graph.h);test/pyimportprecisecheck.sh: the "vocabulary compiled in" arm now greps Python-only patterns, so it fails on a binary without them (checked on v0.6.5 and v0.6.7);queries/python/tags.scm: "the C++ side (ingest_importcap.h) imposes" instead of "C++ imposes".3. CONTRIBUTING family map: row 1 lists Python on
@import.path(#382 merged), and row 2 names Python's current bind producer.Gates: cppqualcheck (plain and ASan: 97 PASS each), pyimportprecisecheck, qschemetripcheck, readmedriftcheck, docanchorcheck, ripwirepubliccheck, gateexitcheck, manifestcheck.
🤖 Generated with Claude Code
Summary by CodeRabbit