Repository navigation
test(cronJobs): cover the labelSync list failure and the sweep non-Error and absent-field branches - #200
Merged
mrbobbytables merged 1 commit intoSep 28, 2026
Conversation
![hivecommons-hive[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…ror and absent-field branches labelSync: listLabelsForRepo rejecting surfaces as 'could not list the repository labels' and writes nothing. sweep: a step rejecting with a plain string is recorded under its name via String(e); a pull request listed without labels or requested_reviewers is treated as unlabelled with no reviewers, so ok-to-test makes no Actions call and blunderbuss still requests them. Closes #199 Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
Contributor
|
Please add a kind label with |
This was referenced Sep 27, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds three tests, in
__tests__/cronJobTest/labelSync.test.tsand__tests__/cronJobTest/sweep.test.tsonly:labelSyncrejects withcould not list the repository labelsand writes nothing whenGET /repos/:o/:r/labelsreturns 500 (src/cronJobs/labelSync.ts:55).sweeprecordsrequire-matching-label: <string>whenenforceRequiredLabelsrejects with a plain string (src/cronJobs/sweep.ts:132).sweeptreats a listed pull request withoutlabels/requested_reviewersas unlabelled with no reviewers: no Actions call fromok-to-test, reviewers still requested byblunderbuss(src/cronJobs/sweep.ts:141,153).labelSync.tsandsweep.tsgo to 100% lines (sweep also 100% branches); full suite 1294 passing, lint unchanged (two pre-existing warnings insrc/utils/auth.ts).Disjoint from #173–#198: none touch these two test files (#179 is
cronJobs/lgtm.ts, #196 is the sweep path inhandleIssueComment).Related Issue
Closes #199
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88