Repository navigation
chore(coverage): raise vitest coverage thresholds to the current floor - #202
Merged
Merged
Conversation
![hivecommons-hive[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Coverage on main is 96.35/94.55/99.14/96.16 (stmts/branches/funcs/lines) while the thresholds were 85/83/91/85, leaving ~11 points of slack. Set them to 95/93/98/95 so a regression of more than about one point fails build-test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
hivecommons-hive
Bot
added
the
hold
Contributor
|
Please add a kind label with |
This was referenced Sep 27, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Raises the
coverage.thresholdsinvitest.config.mjsfrom 85/83/91/85 to 95/93/98/95 (lines/branches/functions/statements).Coverage on
main@ 187c5e3 is 96.35% statements / 94.55% branches / 99.14% functions / 96.16% lines, so the old thresholds left ~11 points of slack and a regression of ~250 statements would passbuild-test. The new values sit about one point under the current floor.Verified:
npx vitest run --coveragepasses (1291 tests) with the new thresholds on this branch.Files:
vitest.config.mjsonly — disjoint from the open error-path test PRs (#173–#200), which touch__tests__/**. Once those land, coverage will be ~99% and the thresholds can be ratcheted again.Related Issue
Closes #201
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88