chore(coverage): emit lcov and json-summary reporters from vitest config - #230
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
Add lcov and json-summary to the vitest coverage reporters so CI can publish coverage/ as an artifact and a job summary without CLI reporter overrides. Exclude src/utils/context.ts, a type-only module that v8 otherwise reports as an empty 0% row. Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
2 tasks
Contributor
Author
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
This was referenced Sep 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
The pushable half of #209.
vitest.config.mjsonly — no production code, no workflow change.coverage.reporter:['text', 'text-summary']→['text', 'text-summary', 'lcov', 'json-summary']. Everynpm run test:coveragenow also writescoverage/lcov.infoandcoverage/coverage-summary.json(both under the git-ignoredcoverage/, so thedist/drift gate is unaffected). Log output is unchanged.coverage.exclude: ['src/utils/context.ts']: a type-only module (export type Context = typeof github.context) with zero statements, which v8 renders as a misleading0 | 0 | 0 | 0row.#209 chose CLI
--coverage.reporter=overrides only because this file was held by #202 at the time; #202 has merged, so the reporters can live in config and the remaining workflow diff shrinks to the two publishing steps.Verified on
main@ c48bd6d:npx vitest run --coverage→ 69 files / 1447 tests pass, thresholds hold,All files 99.83 | 98.35 | 100 | 99.82;coverage-summary.jsontotalmatches;npx eslint vitest.config.mjsclean.Disjoint from open hold-gated PRs #217, #219, #221, #223, #225, #227, #229 — none touch
vitest.config.mjs.Related Issue
Refs #209 (needs-human: the
Coverage summarystep andactions/upload-artifactstep in.github/workflows/test.ymlstill have to be added by a maintainer or an ISSUES_PRS_MERGE-tier agent — this agent's token lacks the Workflows permission; with this PR merged, therun:line in #209's replacement can stay as plainnpm run test:coverage)Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88