test(bundle): drive /remove-help, the built-in /lifecycle defaults and the no-config failure through dist/index.js

[hivecommons-hive]

Test Improvement

Adds __tests__/bundle/labelCommands.test.ts with the three label-command paths dist/index.js is not otherwise driven through:

• /remove-help → reads the issue, deletes Help Wanted and good first issue (case-insensitive match), no POST, then the post-command sweep's configuration reads
• /lifecycle stale with a .prowlabels.yaml that has no lifecycle key → Prow's built-in defaults apply, exclusively: lifecycle/frozen is deleted, then { labels: ['lifecycle/stale'] } is posted
• /lifecycle stale with no configuration file in any tier → exit 1, error contains no prow configuration found, the ten configuration reads and nothing else (the failure docs/labeling.md promises)

comment/repo/token/configReads/helpersFor come from the shared __tests__/bundle/helpers.ts. The other 11 cases of the first revision (/good-first-issue, /remove-good-first-issue, /stage, /status, /priority, the remaining /lifecycle variants) were dropped on review: their lookup tables are unit-tested at help.test.ts:78–133, lifecycle.test.ts:69–120 and priority.test.ts, and bundle.test.ts already exercises the add/remove/exclusive paths via /help, /kind, /remove-kind and /level.

Verification on main @ a270568: npx eslint, npx tsc --noEmit, npx vitest run __tests__/bundle/labelCommands.test.ts — 3 pass.

Related Issue

Closes #245

---

Filed by quality agent (hold-gated mode). Human review required.

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

[jeefy]

These are 14 variations on two lookup tables that are already unit-tested (help.test.ts:78–133, lifecycle.test.ts:69–120, priority.test.ts). The bundle tests already exercise the same add/remove/exclusive paths via /help, /kind, /remove-kind and /level.

1. Trim to the three cases dist/ doesn't yet reach: /remove-help, /lifecycle stale from the built-in defaults, and the no-config failure that docs/labeling.md promises.
2. Use a shared config-read list, comment() and repoLabels() instead of copying them.

[hivecommons-hive]

Addressed both: trimmed to the three cases (/remove-help, /lifecycle stale from the built-in defaults, the no-config failure) and switched to the shared comment/configReads/helpersFor from helpers.ts (#273) instead of local copies. 326 → 73 lines. Rebased on main @ a270568.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: e429462

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

#273 is merged: __tests__/bundle/helpers.ts now exports repo, token, comment(), configReads(), ownersReads, ownersProbe, queueRead, membershipReads(), and via helpersFor(() => gh): calls(), expectRequests(), expectCommandThenConfig() and routeOwners(). Please rebase on main and import these instead of declaring local copies.

repoLabels() isn't in it yet (only one merged suite used it); move it into helpers.ts in this PR and import it from bundle.test.ts too, rather than copying.

[hivecommons-hive]

Rebased on main @ ec76a3b with #273's helpers in place. repoLabels() now lives in __tests__/bundle/helpers.ts; bundle.test.ts imports it instead of its local copy, and labelCommands.test.ts uses it for the GET /labels route too. The suite's other helpers (comment, configReads, helpersFor, repo, token) were already imported. npx eslint __tests__/bundle clean, npx tsc --noEmit clean, npx vitest run __tests__/bundle/labelCommands.test.ts __tests__/bundle/bundle.test.ts → 103 pass.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

Your asks are addressed and it passes on main. Optional: labelsRead (L11) duplicates bundle.test.ts:22, so it could be exported from helpers.ts.

[jeefy]

/kind cleanup
/lgtm
/approve
/hold cancel

[hivecommons-hive]

🔒 Hold-gate integrity: branch changed while hold-gated — fresh review required

This PR's branch moved while it sat hold-gated: the head recorded when the hold was applied was 49ffed37469f, but the branch now sits at cc65969f65ba. The diff a reviewer saw under the hold is no longer the diff that would merge, so auto-merge is blocked and the hold label has been re-applied.

Commits not present in the hold-time snapshot (2):

• 53deae8d3df8 by quality — test(bundle): drive /remove-help, the built-in /lifecycle defaults and the no-config failure through dist/index.js
• cc65969f65ba by quality — test(bundle): move repoLabels into the shared helpers and import it from bundle.test.ts

A human should review the FULL diff at the current head — a rebase or force-push renames every commit, so everything above needs eyes even if it looks familiar. Removing the hold label after that review is the fresh approval: the guard has re-pinned its snapshot to the current head, so a clean lift re-opens the merge lanes.

[jeefy]

/lgtm