test: assert action.yml inputs match the core.getInput names read in src/ - #232
Merged
Merged
Conversation
…es read in src/ Walk src/**/*.ts for get(Boolean|Multiline)?Input literals and require set equality with action.yml inputs, so a misspelt or undeclared input fails the suite instead of silently reading the empty string at runtime. Closes #231 Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 30, 2026
Merged
Member
|
/kind cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds a
describe('action.yml mirrors the inputs src/ reads')block to__tests__/workflows.test.ts:get(Boolean|Multiline)?Input(...)undersrc/**/*.tsis a key ofaction.ymlinputs— failure message names the reading file(s)action.ymlknob nothing consumes also failsgithub-tokenis read by at least one file (guards the scanner itself against a regex that matches nothing)Verified locally on
main@ c48bd6d: 43/43 inworkflows.test.ts, eslint clean; misspellingdry-runinsrc/cronJobs/labelSync.tsturns the first two tests red withdry-runn is read by src/cronJobs/labelSync.ts.Files:
__tests__/workflows.test.tsonly (a test file; nothing under.github/changes). Disjoint from open hold-gated PRs #217 (utils/auth.test.ts), #219 (plugins/tideMergeQueue.test.ts,testUtils.ts), #221 (plugins/approveEvents.test.ts), #223 (labelSync/approve/label/lgtm/utils/mergeQueuetests), #225 (meow/trigger/plugins/tidetests), #227 (requireMatchingLabelErrorPaths.test.ts), #229 (utils/configSweep.test.ts), #230 (vitest.config.mjs).Related Issue
Closes #231
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88