Skip to content

test(bundle): drive the push event and a blank jobs input through the cron dispatcher in dist/index.js - #242

Open
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-bundle-cron-jobs-input
Open

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-bundle-cron-jobs-input

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Test Improvement

Adds __tests__/bundle/cronJobsInput.test.ts with the two jobs-input cases the bundle suite did not reach:

  • the push event routes to the cron dispatcher: with no jobs input the run fails naming the missing list and makes no api call
  • a jobs input of only whitespace is treated as missing

Both assert the message fragment (/please provide a list of space delimited/) rather than the dispatcher's full TypeError: error handling … prefix. The it.each over schedule/workflow_dispatch, the unknown-job case and the bogus\nlabel-sync case were dropped on review: handleCronJob.test.ts and run.test.ts already cover those branches.

Verification on main @ a270568: npx eslint, npx vitest run __tests__/bundle/cronJobsInput.test.ts — 2 pass.

Related Issue

Closes #241


Filed by quality agent (hold-gated mode). Human review required.

@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner September 30, 2026 08:36
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@github-actions

Copy link
Copy Markdown
Contributor

Please add a kind label with /kind failing-test or /kind cleanup.

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleCronJob.test.ts and run.test.ts already cover every branch; only running the push event through the bundle is new.

  1. Match the actual message (/please provide a list of space delimited/, /could not execute tide\./) instead of the full TypeError: error handling issue comment: … string. "issue comment" is a copy-paste bug in handleCronJob.ts.
  2. The bogus\nlabel-sync case really runs label-sync, which gets a 404 that's silently dropped. Either route GET …/labels to return 200 or assert with toContain.
  3. Optional: keep only the push and whitespace-only cases.

jeefy added a commit that referenced this pull request Oct 3, 2026
…ages (#271)

handleCronJob and handlePullReq both copied the issue-comment dispatcher's 'error handling issue comment' TypeError prefix. Report what each one actually dispatches. Unblocks review feedback on #242 and #248.

Signed-off-by: Jeffrey Sica <me@jeefy.dev>
… cron dispatcher in dist/index.js

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot force-pushed the quality/test-bundle-cron-jobs-input branch from d942d0b to 293f94c Compare October 3, 2026 05:13
@hivecommons-hive hivecommons-hive Bot changed the title test(bundle): drive the cron dispatcher's jobs-input error arms and the push route through dist/index.js test(bundle): drive the push event and a blank jobs input through the cron dispatcher in dist/index.js Oct 3, 2026
@hivecommons-hive hivecommons-hive Bot added agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance labels Oct 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Addressed: kept only the push and whitespace-only cases (option 3), both asserting the /please provide a list of space delimited/ fragment; the bogus\nlabel-sync case is gone with it. Rebased on main @ a270568.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 293f94c

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance hold Indicates that a PR should not merge because someone has issued a /hold command. needs-kind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] the cron dispatcher's jobs-input error arms and the push event route are never driven through dist/index.js

1 participant