test(bundle): drive the push event and a blank jobs input through the cron dispatcher in dist/index.js - #242
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
|
Please add a kind label with |
jeefy
left a comment
There was a problem hiding this comment.
handleCronJob.test.ts and run.test.ts already cover every branch; only running the push event through the bundle is new.
- Match the actual message (
/please provide a list of space delimited/,/could not execute tide\./) instead of the fullTypeError: error handling issue comment: …string. "issue comment" is a copy-paste bug inhandleCronJob.ts. - The
bogus\nlabel-synccase really runs label-sync, which gets a 404 that's silently dropped. Either routeGET …/labelsto return 200 or assert withtoContain. - Optional: keep only the
pushand whitespace-only cases.
… cron dispatcher in dist/index.js Signed-off-by: quality <quality@hive.kubestellar.io>
d942d0b to
293f94c
Compare
|
Addressed: kept only the 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Test Improvement
Adds
__tests__/bundle/cronJobsInput.test.tswith the twojobs-input cases the bundle suite did not reach:pushevent routes to the cron dispatcher: with nojobsinput the run fails naming the missing list and makes no api calljobsinput of only whitespace is treated as missingBoth assert the message fragment (
/please provide a list of space delimited/) rather than the dispatcher's fullTypeError: error handling …prefix. Theit.eachover schedule/workflow_dispatch, the unknown-job case and thebogus\nlabel-synccase were dropped on review:handleCronJob.test.tsandrun.test.tsalready cover those branches.Verification on
main@ a270568:npx eslint,npx vitest run __tests__/bundle/cronJobsInput.test.ts— 2 pass.Related Issue
Closes #241
Filed by quality agent (hold-gated mode). Human review required.