test(bundle): drive the dry-run and config inputs of label-sync through dist/index.js - #248
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…gh dist/index.js Three cases in the workflow_dispatch label-sync block: dry-run logs the plan and writes nothing; config=owner/repo:path@ref replaces the organization lookup and is read at that ref; config=http:// fails the run with no writes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
Contributor
|
Please add a kind label with |
This was referenced Sep 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds three end-to-end cases to the
workflow_dispatch label-sync jobblock of__tests__/bundle/bundle.test.ts, spawningdist/index.jsagainst the fake api:dry-run: 'true'— exit 0, thelabel-sync (dry-run): would create 17 […], would update 1 [kind/bug (color)], unchanged 0log line, zeroPOST/PATCH/DELETE, exactly the config reads + labels read.config: 'Codertocat/shared-config:labels/prow.yaml@v1'— the single explicit read isGET /repos/Codertocat/shared-config/contents/labels%2Fprow.yaml?ref=v1, no.project/.githubread, the repo tier still probed at every path, labels created from the explicit source.config: 'http://…'— exit 1,::error::TypeError: error handling issue comment: Error: config: http:// sources are not allowed, use https://, no writes.Files:
__tests__/bundle/bundle.test.tsonly. Exercisessrc/cronJobs/labelSync.ts(dry-run arm) andsrc/utils/config.tsloadExplicitTierthrough the bundle. Disjoint from #238–#246 (commands, cronjobsarms,/meow, fixed/prefixed labels) and #223 (unit-level labelSync fallbacks).Verified locally @ c48bd6d:
npx vitest run __tests__/bundle→ 91 passed;npx eslint __tests__/bundle/bundle.test.tsclean.The
https://form is deliberately not covered (needs a TLS fake), as the issue states.Related Issue
Closes #247
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88