Repository navigation
test(bundle): drive the configured blunderbuss section through dist/index.js - #291
Merged
github-actions[bot] merged 1 commit intoOct 7, 2026
Merged
Conversation
…ndex.js Adds __tests__/bundle/blunderbussSettings.test.ts: pull_request opened against fakeGithub with an org prow.yaml blunderbuss section, covering ignore_authors (case-insensitive skip), exclude_approvers (reviewers only) and max_request_count (one pick left, then none). The bundle suite otherwise runs blunderbuss at its defaults; blunderbuss.ts e2e coverage goes from 56/72 to 63/72 lines. Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
This was referenced Oct 4, 2026
Closed
[quality] bundle e2e never drives plain /close or the /milestone refusals through dist/index.js
#295
Closed
Merged
Member
|
/kind cleanup |
github-actions
Bot
added
kind/cleanup
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
Bot
added
lgtm
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Files:
__tests__/bundle/blunderbussSettings.test.ts(new, bundle e2e). Cluster: the configuredblunderbuss:options insrc/plugins/blunderbuss.tsdriven throughdist/index.js. Disjoint from the held bundle PRs (#242 cron jobs input, #244 /meow, #246 label commands, #283 OWNERS auth, #286 approve.github_review, #289 tide merge gate): none of them drives blunderbuss.Four
pull_request openedruns againstfakeGithub, each with an orgprow.yamlblunderbuss:section and OWNERS files (OWNERSapprover alice,sdk/OWNERSreviewers bob and carol), reusingrouteOwners/repo/tokenfrom./helpers:ignore_authors: ['CODERTOCAT']→blunderbuss: ignoring pull request by codertocat, noPOST …/requested_reviewers(blunderbuss.ts:35, 159–161)exclude_approvers: true→ exactly['bob', 'carol']requested; alice, an approver only, is not a candidate (:171)max_request_count: 2with one already-requested reviewer → one pick (:186)max_request_count: 2with two already requested → no request,#1 already has 2 requested reviewers, max_request_count is 2(:187–189)The bundle suite otherwise runs blunderbuss at its defaults (
bundle.test.ts:1010–1066) andrequest_countthrough/auto-cc(:1068); these options never reacheddist/.Measured with
npm run test:coverage:e2eonmain@ 3fc21f2:blunderbuss.tse2e 56/72 → 63/72 lines, 42/53 → 47/53 branches. Remaining e2e misses are the payload-guard throw,ignore_drafts: false,/auto-ccon a plain issue, the no-candidates return and the API-failure rethrow.npx eslint __tests__/bundleclean;npx vitest run __tests__/bundle/blunderbussSettings.test.ts→ 4 pass.Related Issue
Closes #290
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88