Repository navigation
v1.10.5: fix Import Logs throwing when the view is left before it loads - #18
Merged
Merged
Conversation
The Import Logs view fills its table from IndexedDB in a setTimeout after rendering. Clicking to another view first removed #importLogsBody, and renderImportLog() threw "Cannot set properties of null (setting 'innerHTML')". Look the element up again after the database read and stop if it's gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
Open
Open
gitluis
commented
Nov 2, 2026
gitluis
left a comment
Owner
Author
There was a problem hiding this comment.
Fully reviewed and tested. Approved.
This was referenced Nov 2, 2026
v1.16.2: Fix Rebuild from your folder clearing everything when the folder has no CSV it can read
#25
Open
Open
gitluis
pushed a commit
that referenced
this pull request
Nov 2, 2026
…ettings-database-tab Carries master's v1.10.3-v1.10.5 up the stack: declined answers (#14), literal single "~" (#15) and the Import Logs race fix (#18), with clarity-insights' port of #14 to the rebuilt AI tab. One conflict: CLAUDE.md's "Last updated" line. Kept this branch's line and added the v1.10.3-v1.10.5 history. The CHANGELOG merged cleanly. Versions stay 1.17.0. renderImportLog() keeps #18's guards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
This was referenced Nov 2, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Leaving Settings → Import Logs right after opening it threw a console error. Nothing was lost, but the error appeared every time.
Cause
The view renders synchronously, then fills its table from IndexedDB in a
setTimeout(renders can't be async, CLAUDE.md §15). If you clicked to another view before that finished,#importLogsBodywas gone.renderImportLog()then threwCannot set properties of null (setting 'innerHTML')atviews-data.js:215. The bug has been onmastersince the view was added. I found it while testing #17.What changed
js/views-data.js:#importLogsBodybefore the database read, then looks it up again after the read.renderImportLog()returns early when given no container.Docs and versions: CHANGELOG 1.10.5, the version in
index.html, README (2 places) andviews-settings.js, plus CLAUDE.md §1 and the last-updated line.How it was tested
Headless Chromium against
samples/. The CDNs are blocked in the sandbox, so the same pinned library versions were served from npm; the SRI hashes match.Not verified: Safari and Firefox weren't run.
Noticed, not changed: the changelog embedded in
views-db.js(the Changelog developer view) stops at v1.4.1. Its comment says to update it whenever CHANGELOG.md changes, but no release since has, so I left it alone.Please check before merging
Generated by Claude Code