feat: map the Organizations-area response members from the 1.74.0 gap report - #417
Open
danielabbatt wants to merge 1 commit into
Open
feat: map the Organizations-area response members from the 1.74.0 gap report#417danielabbatt wants to merge 1 commit into
danielabbatt wants to merge 1 commit into
Conversation
… report Thirty members the v1.74.0 spec documents that the models lacked, the first of the per-area batches. Scalars on eleven existing classes, and nested objects backed by six new classes (NextUpgradePredownload, NetworkStatusSummaryGroup, NetworkStatusSummaryPermissions, OrganizationAdaptivePolicyOverviewLimits, OrganizationAssuranceAlertsOverviewByTypeItemNetwork, WebhookAlertTypeExample). Read-only except where the spec puts the member on a request body. Three models in the area never matched the API and are corrected: OrganizationAssuranceAlertsOverviewByTypeItem carried a copy of the by-network item's members; it now has the documented shape and the old SeverityCount type is [Obsolete]. WebhookAlertType had the example payload's fields flattened onto the alert type; the API sends them under "example". They are [Obsolete] at the top level and available on Example. OrganizationDevicesSyslogServersRolesByNetworkItem mapped "availableRoles"; the API sends "available". C# name unchanged. OrganizationsMemberTests covers the new members and the corrected shapes.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 4 complexity
Metric Results Complexity 4
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This was referenced Sep 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #416 → #415
Base is
fix/response-shape-defects. Merge #415 and #416 first (merge commits), then retarget this tomain. Changelog label1.74.9assumes that order.What
The first per-area batch from
gap-report-v1.74.0.md: 30 Organizations-area members the spec documents that the models lacked, across 17 classes. Types and read/write access come from the spec; XML docs are the spec descriptions.LoginSecurity.EnforceLockedIpSessions,NextUpgrade.Strategy,SamlIdp.SsoLoginUrl/.VisionConsumerUrl,OrganizationDevice.Imei, …FirmwareProducts.CampusGateway, bothSwitchCatalyst), 6 need new classesNextUpgradePredownload,NetworkStatusSummaryGroup,NetworkStatusSummaryPermissions,OrganizationAdaptivePolicyOverviewLimits,OrganizationAssuranceAlertsOverviewByTypeItemNetwork,WebhookAlertTypeExampleNextUpgrade.Strategyis astring?rather than an enum (minimizeClientDowntime/minimizeUpgradeTime) so an unlisted value can't break deserialization.Three corrections, not just additions
The diff surfaced three models in this area that never matched the API. Reading their old members always gave defaults, so changing them is breaking only in the type-system sense:
OrganizationAssuranceAlertsOverviewByTypeItemwas a copy of the by-network item (AlertCount,NetworkId,NetworkName,SeverityCounts). The API sendstype,categoryType,severity,count,networkCount,networks,deviceTypes,deviceTags,lastAlertedAt,lastResolvedAt. Rebuilt to that;…SeverityCountis[Obsolete].WebhookAlertTypehad the example payload's 19 fields flattened onto the alert type. The API sends{alertTypeId, alertType, example}. The flattened ones are[Obsolete]pointing at the newExample, which also carries five fields they never had.OrganizationDevicesSyslogServersRolesByNetworkItem.AvailableRolesmappedavailableRoles; the API sendsavailable. DataMember fixed, C# name kept.Verification
All 18 edited model files kept their BOM state and CRLF. No code outside
Datareferenced the corrected members.Next
Remaining areas in the report, largest first: SM (27), Appliance (25), Wireless (19), General (10), Camera (8), CellularGateway (7), Switch (7), Sensor (6), LiveTools (2), Licensing (1).