Repository navigation
test: assert the Node runtime major agrees across action.yml, package.json, README and setup-node - #234
Merged
Conversation
….json, README and setup-node Adds __tests__/runtime.test.ts, a manifest drift guard in the style of workflows.test.ts: action.yml runs.using must be the floor of engines.node, the major of @types/node and the runtime the README names, and every actions/setup-node step must read node-version-file: package.json rather than pin node-version by hand. Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 30, 2026
Merged
Member
|
/kind cleanup |
github-actions
Bot
added
kind/cleanup
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/runtime.test.ts(new file; touches nothing else) — a manifest drift guard in the style of__tests__/workflows.test.ts, for the Node runtime major:action.ymlruns.usingmatches^node\d+$andruns.mainisdist/index.jspackage.jsonengines.nodeis exactly>=<major>and@types/nodeis exactly^<major>README.mdnames the same`nodeNN` runtimefor self-hosted runner operatorsactions/setup-nodestep in.github/workflows/*.ymlreadsnode-version-file: package.jsonand never pinsnode-versionby handVerified locally on
main@ c48bd6d: 9 tests pass;eslintandtsc --noEmitclean. Mutatingruns.usingtonode26fails the three cross-manifest assertions, so the guard bites.Disjoint from #232 (action inputs,
__tests__/workflows.test.ts) and from thesrc/branch-coverage PRs #217–#229.Related Issue
Closes #233
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88