test(plugins): cover the non-Error rejection arm of the requireMatchingLabel error report

[hivecommons-hive]

Test Improvement

Adds one case to describe('requireMatchingLabel handler') in __tests__/plugins/requireMatchingLabel.test.ts: when labelIssue rejects with a non-Error value (vi.spyOn(labeling, 'labelIssue').mockRejectedValueOnce('rate limited'), the same pattern as sweep.test.ts:189), the per-rule report carries the value verbatim — require-matching-label needs-kind: rate limited. That is the String(error) arm of src/plugins/requireMatchingLabel.ts, which every octokit failure (always an Error) skips.

Reuses serveRules/serveIssue/issueEvent/kindRule; no new file, no module-wide vi.mock. The earlier separate requireMatchingLabelErrorPaths.test.ts and its "still applies the other rules" assertion were dropped on review (requireMatchingLabel.test.ts:392 already covers the latter).

Verification on main @ a270568: npx eslint, npx tsc --noEmit, npx vitest run __tests__/plugins/requireMatchingLabel.test.ts — 50 pass.

Related Issue

Closes #226

---

Filed by quality agent (hold-gated mode). Human review required.

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

[hivecommons-hive]

/kind cleanup

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c48bd6d

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

It hits the branch, but it's a new 64-line file for one branch that only mocks can reach.

1. Move the case into __tests__/plugins/requireMatchingLabel.test.ts and reuse serveRules/serveIssue/issueEvent/kindRule. rulesYaml is copied word for word, and describe('requireMatchingLabel error paths') already exists in pluginErrorPaths.test.ts.
2. Replace the file-wide vi.mock(..., { spy: true }) with vi.spyOn(labeling, 'labelIssue').mockRejectedValueOnce('rate limited'), the same pattern as sweep.test.ts:189.
3. Assert only the needs-kind: rate limited message. "Still applies the other rules" is already covered at requireMatchingLabel.test.ts:392.

[hivecommons-hive]

Addressed all three: the case now lives in requireMatchingLabel.test.ts reusing serveRules/serveIssue/issueEvent/kindRule, uses vi.spyOn(labeling, 'labelIssue').mockRejectedValueOnce('rate limited') instead of a file-wide vi.mock, and asserts only the needs-kind: rate limited message. The separate file is deleted. Rebased on main @ a270568.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 9bf3ea9

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

Asks addressed, thanks.

[jeefy]

/kind cleanup
/lgtm
/approve
/hold cancel