test(config): cover the empty sweep mapping and non-Error lookback rethrow branches of normalizeSweep - #229
Merged
Conversation
…throw branches of normalizeSweep Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
Contributor
Author
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
This was referenced Sep 29, 2026
Merged
Member
|
/kind cleanup |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/utils/configSweep.test.tscovering the two remaining uncovered branch arms ofnormalizeSweepinsrc/utils/config.ts:sweep: {}— a mapping with nolookbackparses to{ sweep: {} }(line 594 false arm).Errorvalue thrown byparseDuration(spied viavi.mock(..., { spy: true })) is stringified intox: <value>(line 603 fallback arm).config.tsgoes from 99.03% to 100% branch coverage;npm testandnpm run lintpass onmain@ c48bd6d.Files/functions claimed:
__tests__/utils/configSweep.test.ts(new) →normalizeSweepinsrc/utils/config.ts. Disjoint from #217, #219, #221, #223, #225 and #227, none of which touchconfig.tsor a config test.Related Issue
Closes #228
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88