Skip to content

test(config): cover the empty sweep mapping and non-Error lookback rethrow branches of normalizeSweep - #229

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-config-sweep-fallbacks
Oct 3, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-config-sweep-fallbacks

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds __tests__/utils/configSweep.test.ts covering the two remaining uncovered branch arms of normalizeSweep in src/utils/config.ts:

  • sweep: {} — a mapping with no lookback parses to { sweep: {} } (line 594 false arm).
  • a non-Error value thrown by parseDuration (spied via vi.mock(..., { spy: true })) is stringified into x: <value> (line 603 fallback arm).

config.ts goes from 99.03% to 100% branch coverage; npm test and npm run lint pass on main @ c48bd6d.

Files/functions claimed: __tests__/utils/configSweep.test.ts (new) → normalizeSweep in src/utils/config.ts. Disjoint from #217, #219, #221, #223, #225 and #227, none of which touch config.ts or a config test.

Related Issue

Closes #228


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…throw branches of normalizeSweep

Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner September 29, 2026 07:40
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/kind cleanup


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c48bd6d

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind labels Sep 29, 2026
@jeefy

jeefy commented Oct 2, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 2, 2026
@github-actions
github-actions Bot merged commit 61577d5 into main Oct 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] normalizeSweep in src/utils/config.ts: empty sweep mapping and non-Error lookback rethrow branches are untested

1 participant