Skip to content

test: cover the residual branch fallbacks of meow, trigger and tide - #225

Open
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-residual-branch-fallbacks
Open

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-residual-branch-fallbacks

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds seven tests for the branch arms no open PR claims, each in the file that already covers the function:

Test file Source arm
__tests__/issueCommentTest/meow.test.ts meow.ts:88 — a Response.error() (status 0) is named cat api responded with a redirect in the warning; the note is still posted
__tests__/issueCommentTest/trigger.test.ts trigger.ts:323 — approvePendingRuns with approveWorkflowRun rejecting a bare string: statusOf reads no status, run fails with could not approve run 8 (CI): nope
__tests__/plugins/tide.test.ts tide.ts:108 — fetchMergeability with the state computed on the read after the last wait: 4 reads, 3 sleeps, no "still unknown" info line
__tests__/plugins/tide.test.ts tide.ts:137–138 — mergeOnce on a non-Error rejection → { result: 'failed', message: 'nope', status: undefined }
__tests__/plugins/tide.test.ts tide.ts:256 — fork 403 whose compare response has no files list is read as no workflow files behind → failed, no comment
__tests__/plugins/tide.test.ts tide.ts:424 — pull without a draft field maps to draft: false
__tests__/plugins/tide.test.ts tide.ts:543 — loadTide without a base reads the default-branch tree (repoHasOwners) and resolves [lgtm, approved]

Result on main @ c48bd6d: 1454 tests pass; meow.ts and trigger.ts 100% branches; tide.ts branch coverage 94.62% → 97.84%, leaving exactly the evaluateMerge lines #219 claims (304, 329–330, 361). Thresholds hold. No source changes.

Disjoint from open hold-gated PRs: #217 (__tests__/utils/auth.test.ts), #219 (__tests__/plugins/tideMergeQueue.test.ts, __tests__/testUtils.ts), #221 (__tests__/plugins/approveEvents.test.ts), #223 (labelSync, issueCommentTest/approve, label/lgtm, utils/mergeQueue tests).

Related Issue

Closes #224


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

meow.ts:88 status-0 message, trigger.ts:323 statusOf on a non-object
rejection, tide.ts:108 state computed on the read after the last wait,
tide.ts:137-138 mergeOnce on a non-Error rejection, tide.ts:256 compare
without a files list, tide.ts:424 pull without a draft field.

Closes #224

Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner September 29, 2026 01:32
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/kind cleanup


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c48bd6d

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] residual untested branch fallbacks in meow.ts, trigger.ts and tide.ts (outside #217/#219/#221/#223)

0 participants