test: cover the residual branch fallbacks of meow, trigger and tide - #225
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
meow.ts:88 status-0 message, trigger.ts:323 statusOf on a non-object rejection, tide.ts:108 state computed on the read after the last wait, tide.ts:137-138 mergeOnce on a non-Error rejection, tide.ts:256 compare without a files list, tide.ts:424 pull without a draft field. Closes #224 Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 29, 2026
Contributor
Author
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
This was referenced Sep 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds seven tests for the branch arms no open PR claims, each in the file that already covers the function:
__tests__/issueCommentTest/meow.test.tsmeow.ts:88— aResponse.error()(status 0) is namedcat api responded with a redirectin the warning; the note is still posted__tests__/issueCommentTest/trigger.test.tstrigger.ts:323—approvePendingRunswithapproveWorkflowRunrejecting a bare string:statusOfreads no status, run fails withcould not approve run 8 (CI): nope__tests__/plugins/tide.test.tstide.ts:108—fetchMergeabilitywith the state computed on the read after the last wait: 4 reads, 3 sleeps, no "still unknown" info line__tests__/plugins/tide.test.tstide.ts:137–138—mergeOnceon a non-Errorrejection →{ result: 'failed', message: 'nope', status: undefined }__tests__/plugins/tide.test.tstide.ts:256— fork 403 whose compare response has nofileslist is read as no workflow files behind →failed, no comment__tests__/plugins/tide.test.tstide.ts:424— pull without adraftfield maps todraft: false__tests__/plugins/tide.test.tstide.ts:543—loadTidewithout a base reads the default-branch tree (repoHasOwners) and resolves[lgtm, approved]Result on
main@ c48bd6d: 1454 tests pass;meow.tsandtrigger.ts100% branches;tide.tsbranch coverage 94.62% → 97.84%, leaving exactly theevaluateMergelines #219 claims (304, 329–330, 361). Thresholds hold. No source changes.Disjoint from open hold-gated PRs: #217 (
__tests__/utils/auth.test.ts), #219 (__tests__/plugins/tideMergeQueue.test.ts,__tests__/testUtils.ts), #221 (__tests__/plugins/approveEvents.test.ts), #223 (labelSync,issueCommentTest/approve,label/lgtm,utils/mergeQueuetests).Related Issue
Closes #224
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88