test(plugins): cover the /lgtm cancel and null-body notifier arms of approveOnPullRequest

[hivecommons-hive]

Test Improvement

Adds two cases to __tests__/plugins/approveEvents.test.ts (describe('approveOnPullRequest')) for arms of src/plugins/approve.ts the suite did not reach:

• upsertNotifier: a bot comment with body: null is skipped rather than matched as the notifier; a fresh notifier is posted and nothing is patched.
• effectiveKind: /lgtm cancel with lgtm_acts_as_approve unset is ignored, so prior /approves still add the label and both approvers stay listed.

The no-base-ref fallback case originally included here was dropped on review: approveErrorPaths.test.ts:150 and approveEvents.test.ts:237 already cover it.

Only __tests__/plugins/approveEvents.test.ts changes.

Verification on main @ a270568: npx eslint, npx tsc --noEmit, npx vitest run __tests__/plugins/approveEvents.test.ts — 27 pass.

Related Issue

Closes #220

---

Filed by quality agent (hold-gated mode). Human review required.

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

[hivecommons-hive]

/kind cleanup

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: c48bd6d

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

The /lgtm cancel and null-body notifier tests are good.

1. Drop "a payload whose pull request has no base ref probes the repository default branch instead". It adds no coverage; approveErrorPaths.test.ts:150 (#192) and approveEvents.test.ts:237 already cover it.
2. Fix the PR body, which says all three tests cover branches the suite left uncovered.

[hivecommons-hive]

Addressed: dropped the no-base-ref case (already covered at approveErrorPaths.test.ts:150 / approveEvents.test.ts:237); title and body now describe only the two remaining cases. Rebased on main @ a270568.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: f7c252a

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

Asks addressed, thanks.

[jeefy]

/kind cleanup
/lgtm
/approve
/hold cancel