test: cover the non-Error rejection and empty-config fallbacks of labelSync, lgtm, mergeQueue and issueComment/approve - #223
Open
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…elSync, lgtm, mergeQueue and issueComment/approve Closes #222 Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 29, 2026
Contributor
Author
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
This was referenced Sep 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Closes the last uncovered branches in four modules (unit coverage on
main@ c48bd6d: 98.35% → 98.68% branches; each touched file now 100% branches). No production code changes.__tests__/cronJobTest/labelSync.test.tslabelSync.ts:48debug line when no prow config is found;labelSync.ts:107write()catch whenissues.createLabelrejects with a bare string (newOctokitspy-mocked, one label refused, the rest still written, run fails namingkind/bug (offline))__tests__/label/lgtm.test.tslgtm.ts:68bindLgtmrejecting a non-Error(lgtmBindingspy-mocked): refusal comment carries the string form, no label,setFailed__tests__/utils/mergeQueue.test.tsmergeQueue.ts:188errorMessage()for a non-Errorgraphqlrejection inqueueState__tests__/issueCommentTest/approve.test.tsapprove.ts:94issue?.user?.login ?? ''—require_self_approvalwith a payload whose issue has nouseris not treated as self-approvalVerified:
npx vitest run --coverage→ 69 files / 1452 tests pass, thresholds hold;npx eslintclean on the four files.Disjoint from open hold-gated PRs #217 (
auth.test.ts), #219 (tideMergeQueue.test.ts,testUtils.ts), #221 (plugins/approveEvents.test.ts).Related Issue
Closes #222
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88